added checking for missing INFO chunk when loading tape by filename only

[rocksndiamonds.git] / src / tape.c

diff --git a/src/tape.c b/src/tape.c
index 62cb3e0d102785f5d5dec5c879c9ce55bddecd65..d77703295f3fcb5ee69619d658bd713de42e36b5 100644 (file)
--- a/src/tape.c
+++ b/src/tape.c
@@ -1427,9 +1427,10 @@ static void AutoPlayTapes_WaitForUpload(void)
   Print("- uploading score tape to score server - uploaded.\n");
 }
 
-static void AutoPlayTapesExt(boolean initialize)
+static int AutoPlayTapesExt(boolean initialize)
 {
   static struct AutoPlayInfo autoplay;
+  static int num_tapes = 0;
   static int patch_nr = 0;
   static char *patch_name[] =
   {
@@ -1528,6 +1529,7 @@ static void AutoPlayTapesExt(boolean initialize)
 
       // save score tape to upload to server; may be required for some reasons:
       // * level set identifier in solution tapes may differ from level set
+      // * level set identifier is missing (old-style tape without INFO chunk)
       // * solution tape may have native format (like Supaplex solution files)
 
       SaveScoreTape(level_nr);
@@ -1587,6 +1589,9 @@ static void AutoPlayTapesExt(boolean initialize)
          Fail("cannot load tape file '%s'", autoplay.tape_filename);
       }
 
+      if (tape.no_info_chunk)
+       Fail("cannot get levelset from tape file '%s'", autoplay.tape_filename);
+
       global.autoplay_leveldir = tape.level_identifier;
 
       if (tape.level_nr >= 0 && tape.level_nr < MAX_TAPES_PER_SET)
@@ -1614,6 +1619,11 @@ static void AutoPlayTapesExt(boolean initialize)
     if (global.autoplay_mode == AUTOPLAY_MODE_FIX)
       options.mytapes = TRUE;
 
+    // set timestamp for batch tape upload
+    global.autoplay_time = time(NULL);
+
+    num_tapes = 0;
+
     init_level_set = TRUE;
   }
 
@@ -1768,6 +1778,8 @@ static void AutoPlayTapesExt(boolean initialize)
       }
     }
 
+    num_tapes++;
+
     if (global.autoplay_mode == AUTOPLAY_MODE_UPLOAD)
     {
       boolean use_temporary_tape_file = FALSE;
@@ -1781,9 +1793,21 @@ static void AutoPlayTapesExt(boolean initialize)
        autoplay.tape_filename = (options.mytapes ? getTapeFilename(level_nr) :
                                  getDefaultSolutionTapeFilename(level_nr));
 
-       if (!fileExists(autoplay.tape_filename))
+       boolean correct_info_chunk =
+         (strEqual(leveldir_current->identifier, tape.level_identifier) &&
+          level_nr == tape.level_nr);
+
+       if (!correct_info_chunk)
        {
-         // non-standard solution tape -- save to temporary file
+         strncpy(tape.level_identifier, leveldir_current->identifier,
+                 MAX_FILENAME_LEN);
+         tape.level_identifier[MAX_FILENAME_LEN] = '\0';
+         tape.level_nr = level_nr;
+       }
+
+       if (!fileExists(autoplay.tape_filename) || !correct_info_chunk)
+       {
+         // non-standard or incorrect solution tape -- save to temporary file
          autoplay.tape_filename = getTemporaryTapeFilename();
 
          SaveTapeToFilename(autoplay.tape_filename);
@@ -1815,21 +1839,26 @@ static void AutoPlayTapesExt(boolean initialize)
 
     autoplay.last_level_nr = level_nr;
 
-    return;
+    return num_tapes;
   }
 
+  // clear timestamp for batch tape upload (required after interactive upload)
+  global.autoplay_time = 0;
+
   if (program.headless)
     CloseAllAndExit(0);
+
+  return num_tapes;
 }
 
-void AutoPlayTapes(void)
+int AutoPlayTapes(void)
 {
-  AutoPlayTapesExt(TRUE);
+  return AutoPlayTapesExt(TRUE);
 }
 
-void AutoPlayTapesContinue(void)
+int AutoPlayTapesContinue(void)
 {
-  AutoPlayTapesExt(FALSE);
+  return AutoPlayTapesExt(FALSE);
 }