X-Git-Url: https://git.artsoft.org/?a=blobdiff_plain;f=src%2Flibgame%2Fpcx.c;h=c7b308b0900a4d56644f73823e7248c173131fb3;hb=76510834f382bc82548e72c8e7f6f7672c9484dc;hp=7f6d7f2da42ad9407a0a6fa7b4d779aaabf9ea92;hpb=c9433eab5c4317ed4f89164b386a7d33562e29be;p=rocksndiamonds.git

diff --git a/src/libgame/pcx.c b/src/libgame/pcx.c
index 7f6d7f2d..c7b308b0 100644
--- a/src/libgame/pcx.c
+++ b/src/libgame/pcx.c
@@ -19,7 +19,7 @@
 #include "misc.h"
 
 
-#define PCX_DEBUG		FALSE
+#define PCX_DEBUG		0
 
 #define PCX_MAGIC		0x0a	/* first byte in a PCX image file    */
 #define PCX_SUPPORTED_VERSION	5	/* last acceptable version number    */
@@ -112,7 +112,7 @@ static boolean PCX_ReadBitmap(FILE *file, struct PCX_Header *pcx, Image *image)
   for (y = 0; y < height; y++)
   {
     /* decode a scan line into a temporary buffer first */
-    byte *dst_ptr = (pcx_depth == 8) ? bitmap_ptr : row_buffer;
+    byte *dst_ptr = (pcx_depth == 8 ? bitmap_ptr : row_buffer);
     byte value = 0, count = 0;
     int value_int;
     int i;
@@ -122,14 +122,23 @@ static boolean PCX_ReadBitmap(FILE *file, struct PCX_Header *pcx, Image *image)
       if (count == 0)
       {
 	if ((value_int = fgetc(file)) == EOF)
+	{
+	  free(row_buffer);
 	  return FALSE;
+	}
+
 	value = (byte)value_int;
 
 	if ((value & 0xc0) == 0xc0)	/* this is a repeat count byte */
 	{
 	  count = value & 0x3f;		/* extract repeat count from byte */
+
 	  if ((value_int = fgetc(file)) == EOF)
+	  {
+	    free(row_buffer);
 	    return FALSE;
+	  }
+
 	  value = (byte)value_int;
 	}
 	else
@@ -152,14 +161,18 @@ static boolean PCX_ReadBitmap(FILE *file, struct PCX_Header *pcx, Image *image)
       {
 	int i, j, x = 0;
 
-	for(i = 0; i < pcx->bytes_per_line; i++)
+	for (i = 0; i < pcx->bytes_per_line; i++)
 	{
 	  byte value = *src_ptr++;
 
-	  for(j = 7; j >= 0; j--)
+	  for (j = 7; j >= 0; j--)
 	  {
-	    byte bit = (value >> j) & 1;
+	    byte bit;
+
+	    if (i * 8 + j >= width)	/* skip padding bits */
+	      continue;
 
+	    bit = (value >> j) & 1;
 	    bitmap_ptr[x++] |= bit << plane;
 	  }
 	}
@@ -170,12 +183,12 @@ static boolean PCX_ReadBitmap(FILE *file, struct PCX_Header *pcx, Image *image)
       byte *src_ptr = row_buffer;
       int plane;
 
-      for(plane = 0; plane < pcx->color_planes; plane++)
+      for (plane = 0; plane < pcx->color_planes; plane++)
       {
 	int x;
 
 	dst_ptr = bitmap_ptr + plane;
-	for(x = 0; x < width; x++)
+	for (x = 0; x < width; x++)
 	{
 	  *dst_ptr = *src_ptr++;
 	  dst_ptr += pcx->color_planes;
@@ -186,6 +199,8 @@ static boolean PCX_ReadBitmap(FILE *file, struct PCX_Header *pcx, Image *image)
     bitmap_ptr += image->bytes_per_row;
   }
 
+  free(row_buffer);
+
   return TRUE;
 }
 
@@ -321,6 +336,7 @@ Image *Read_PCX_to_Image(char *filename)
 #if PCX_DEBUG
   if (options.verbose)
   {
+    printf("\n");
     printf("%s is a %dx%d PC Paintbrush image\n", filename, width, height);
     printf("depth: %d\n", depth);
     printf("bits_per_pixel: %d\n", pcx.bits_per_pixel);
@@ -360,7 +376,6 @@ Image *Read_PCX_to_Image(char *filename)
   if (pcx_depth == 8)
   {
     /* determine number of used colormap entries for 8-bit PCX images */
-    image->rgb.used = 0;
     for (i=0; i<PCX_MAXCOLORS; i++)
       if (image->rgb.color_used[i])
 	image->rgb.used++;
@@ -368,7 +383,7 @@ Image *Read_PCX_to_Image(char *filename)
 
 #if PCX_DEBUG
   if (options.verbose)
-    printf("Read_PCX_to_Image: %d colors found\n", image->rgb.used);
+    printf("Read_PCX_to_Image: %d colors in colormap\n", image->rgb.used);
 #endif
 
   return image;