X-Git-Url: https://git.artsoft.org/?a=blobdiff_plain;f=src%2Flibgame%2Fhttp.c;h=b494ac42bd9d57d04bf84f14ed3d6189ef35c305;hb=97b1e9813e532b9065a841f2d185d632df19bf7a;hp=74fafb379713e61b5d4d7a9edf768da73090a896;hpb=db269a1ab34d16c03e8087eaf786e7b3c9a135e4;p=rocksndiamonds.git

diff --git a/src/libgame/http.c b/src/libgame/http.c
index 74fafb37..b494ac42 100644
--- a/src/libgame/http.c
+++ b/src/libgame/http.c
@@ -37,7 +37,9 @@ void ConvertHttpRequestBodyToServerEncoding(struct HttpRequest *request)
 {
   char *body_utf8 = getUTF8FromLatin1(request->body);
 
-  strcpy(request->body, body_utf8);
+  strncpy(request->body, body_utf8, MAX_HTTP_BODY_SIZE);
+  request->body[MAX_HTTP_BODY_SIZE] = '\0';
+
   checked_free(body_utf8);
 }
 
@@ -45,10 +47,12 @@ void ConvertHttpResponseBodyToClientEncoding(struct HttpResponse *response)
 {
   char *body_latin1 = getLatin1FromUTF8(response->body);
 
-  strcpy(response->body, body_latin1);
-  checked_free(body_latin1);
+  strncpy(response->body, body_latin1, MAX_HTTP_BODY_SIZE);
+  response->body[MAX_HTTP_BODY_SIZE] = '\0';
 
   response->body_size = strlen(response->body);
+
+  checked_free(body_latin1);
 }
 
 static void SetHttpResponseToDefaults(struct HttpResponse *response)
@@ -146,8 +150,11 @@ static boolean SetHTTPResponseBody(struct HttpResponse *response, char *buffer,
   return TRUE;
 }
 
-boolean DoHttpRequest(struct HttpRequest *request,
-		      struct HttpResponse *response)
+static boolean DoHttpRequestExt(struct HttpRequest *request,
+				struct HttpResponse *response,
+				char *send_buffer,
+				char *recv_buffer,
+				int max_http_buffer_size)
 {
   SDLNet_SocketSet socket_set;
   TCPsocket socket;
@@ -213,10 +220,6 @@ boolean DoHttpRequest(struct HttpRequest *request,
 	   request->hostname,
 	   (int)strlen(request->body));
 
-  int max_http_buffer_size = MAX_HTTP_HEAD_SIZE + MAX_HTTP_BODY_SIZE;
-  char send_buffer[max_http_buffer_size + 1];
-  char recv_buffer[max_http_buffer_size + 1];
-
   snprintf(send_buffer, max_http_buffer_size,
 	   "%s\r\n%s", request->head, request->body);
 
@@ -276,3 +279,22 @@ boolean DoHttpRequest(struct HttpRequest *request,
 
   return TRUE;
 }
+
+boolean DoHttpRequest(struct HttpRequest *request,
+		      struct HttpResponse *response)
+{
+  int max_http_buffer_size = MAX_HTTP_HEAD_SIZE + MAX_HTTP_BODY_SIZE;
+  char *send_buffer = checked_malloc(max_http_buffer_size + 1);
+  char *recv_buffer = checked_malloc(max_http_buffer_size + 1);
+
+  boolean success = DoHttpRequestExt(request, response,
+				     send_buffer, recv_buffer,
+				     max_http_buffer_size);
+
+  checked_free(send_buffer);
+  checked_free(recv_buffer);
+
+  runtime.use_api_server = success;
+
+  return success;
+}