rnd-20021129-3-src

[rocksndiamonds.git] / src / libgame / misc.c

diff --git a/src/libgame/misc.c b/src/libgame/misc.c
index 498a96e89231d3c9de9fa47ad680ba1d948a6e67..7637dc2d8473efc6ac661c9bd93a12c49d131b7c 100644 (file)
--- a/src/libgame/misc.c
+++ b/src/libgame/misc.c
@@ -1362,7 +1362,7 @@ struct FileInfo *getFileListFromConfigList(struct ConfigInfo *config_list,
 {
   struct FileInfo *file_list;
   int num_suffix_list_entries = 0;
-  int list_pos = -1;
+  int list_pos = 0;
   int i, j;
 
   file_list = checked_calloc(num_file_list_entries * sizeof(struct FileInfo));
@@ -1373,9 +1373,9 @@ struct FileInfo *getFileListFromConfigList(struct ConfigInfo *config_list,
   /* always start with reliable default values */
   for (i=0; i<num_file_list_entries; i++)
   {
-    file_list[list_pos].token = NULL;
-    file_list[list_pos].default_filename = NULL;
-    file_list[list_pos].filename = NULL;
+    file_list[i].token = NULL;
+    file_list[i].default_filename = NULL;
+    file_list[i].filename = NULL;
 
     if (num_suffix_list_entries > 0)
     {
@@ -1397,6 +1397,7 @@ struct FileInfo *getFileListFromConfigList(struct ConfigInfo *config_list,
   for (i=0; config_list[i].token != NULL; i++)
   {
     int len_config_token = strlen(config_list[i].token);
+    int len_config_value = strlen(config_list[i].value);
     boolean is_file_entry = TRUE;
 
     for (j=0; suffix_list[j].token != NULL; j++)
@@ -1416,10 +1417,21 @@ struct FileInfo *getFileListFromConfigList(struct ConfigInfo *config_list,
 
     if (is_file_entry)
     {
-      list_pos++;
+      if (i > 0)
+       list_pos++;
 
-      if (list_pos >= num_file_list_entries)
-       Error(ERR_EXIT, "inconsistant config list information -- please fix");
+      if (list_pos > num_file_list_entries - 1)
+       break;
+
+      /* simple sanity check if this is really a file definition */
+      if (strcmp(&config_list[i].value[len_config_value - 4], ".pcx") != 0 &&
+         strcmp(&config_list[i].value[len_config_value - 4], ".wav") != 0 &&
+         strcmp(config_list[i].value, UNDEFINED_FILENAME) != 0)
+      {
+       Error(ERR_RETURN, "Configuration directive '%s' -> '%s':",
+             config_list[i].token, config_list[i].value);
+       Error(ERR_EXIT, "This seems to be no valid definition -- please fix");
+      }
 
       file_list[list_pos].token = config_list[i].token;
       file_list[list_pos].default_filename = config_list[i].value;
@@ -1464,8 +1476,11 @@ static void LoadArtworkConfig(struct ArtworkListInfo *artwork_info)
   {
     for (i=0; i<num_file_list_entries; i++)
     {
-      file_list[i].filename =
-       getStringCopy(getTokenValue(setup_file_list, file_list[i].token));
+      char *filename = getTokenValue(setup_file_list, file_list[i].token);
+
+      if (filename == NULL)
+       filename = file_list[i].default_filename;
+      file_list[i].filename = getStringCopy(filename);
 
       for (j=0; j<num_suffix_list_entries; j++)
       {
@@ -1474,6 +1489,8 @@ static void LoadArtworkConfig(struct ArtworkListInfo *artwork_info)
 
        if (value != NULL)
          file_list[i].parameter[j] = atoi(value);
+
+       free(token);
       }
     }
 
@@ -1552,6 +1569,10 @@ static void replaceArtworkListEntry(struct ArtworkListInfo *artwork_info,
   }
   else if ((*listnode = artwork_info->load_artwork(filename)) != NULL)
   {
+#if 0
+      printf("[adding new artwork '%s']\n", filename);
+#endif
+
     (*listnode)->num_references = 1;
     addNodeToList(&artwork_info->content_list, (*listnode)->source_filename,
                  *listnode);
@@ -1629,7 +1650,7 @@ void ReloadCustomArtworkList(struct ArtworkListInfo *artwork_info)
     DrawInitText(draw_init[artwork_info->type].text, 120, FC_GREEN);
 
 #if 0
-  printf("DEBUG: reloading %d sounds ...\n", num_file_list_entries);
+  printf("DEBUG: reloading %d artwork files ...\n", num_file_list_entries);
 #endif
 
   for(i=0; i<num_file_list_entries; i++)
@@ -1637,10 +1658,11 @@ void ReloadCustomArtworkList(struct ArtworkListInfo *artwork_info)
     if (draw_init[artwork_info->type].do_it)
       DrawInitText(file_list[i].token, 150, FC_YELLOW);
 
-    if (file_list[i].filename)
-      LoadArtworkToList(artwork_info, file_list[i].filename, i);
-    else
-      LoadArtworkToList(artwork_info, file_list[i].default_filename, i);
+    LoadArtworkToList(artwork_info, file_list[i].filename, i);
+
+#if 0
+    printf("DEBUG:   loading artwork file '%s'...\n", file_list[i].filename);
+#endif
   }
 
   draw_init[artwork_info->type].do_it = FALSE;