Image *newImage(unsigned int width, unsigned int height, unsigned int depth)
{
Image *image;
- const unsigned int bytes_per_pixel = 1;
+ unsigned int bytes_per_pixel = (depth + 7) / 8;
int i;
+#if 0
if (depth > 8)
Error(ERR_EXIT, "images with more than 256 colors are not supported");
depth = 8;
+#endif
image = checked_malloc(sizeof(Image));
image->data = checked_malloc(width * height * bytes_per_pixel);
image->width = width;
image->height = height;
image->depth = depth;
- image->rgb.used = 0;
+ image->bytes_per_pixel = bytes_per_pixel;
+ image->bytes_per_row = width * bytes_per_pixel;
+ image->rgb.used = 0;
for (i=0; i<MAX_COLORS; i++)
image->rgb.color_used[i] = FALSE;
image->type = (depth < 8 ? IMAGETYPE_BITMAP :
depth > 8 ? IMAGETYPE_TRUECOLOR : IMAGETYPE_RGB);
- image->bytes_per_row = (depth + 7) / 8;
- image->bytes_per_row *= width;
-
return image;
}
{
byte *src_ptr, *dst_ptr, *dst_ptr2;
unsigned int bytes_per_row;
- unsigned int x, y;
+ unsigned int x, y, i;
byte bitmask;
byte *mask_data;
Pixmap mask_pixmap;
for (x=0; x<image->width; x++)
{
- if (*src_ptr++) /* source pixel solid? (pixel index != 0) */
- *dst_ptr2 |= bitmask; /* then write a bit into the image mask */
+ for (i=0; i<image->bytes_per_pixel; i++)
+ if (*src_ptr++) /* source pixel solid? (pixel index != 0) */
+ *dst_ptr2 |= bitmask; /* then write a bit into the image mask */
if ((bitmask <<= 1) == 0) /* bit at rightmost byte position reached? */
{
static int num_cmap_entries, free_cmap_entries;
static boolean private_cmap = FALSE;
Pixel *redvalue, *greenvalue, *bluevalue;
- unsigned int a, c = 0, x, y, bytes_per_pixel, bits_per_pixel;
+ unsigned int display_bytes_per_pixel, display_bits_per_pixel;
+ unsigned int a, c = 0, x, y;
XColor xcolor;
XImage *ximage;
XImageInfo *ximageinfo;
byte *src_ptr, *dst_ptr;
+ char *error = "Image_to_Pixmap(): %s";
+
+ if (image->type == IMAGETYPE_TRUECOLOR && depth == 8)
+ {
+ SetError(error, "cannot handle true-color images on 8-bit display");
+ return NULL;
+ }
if (!global_cmap)
{
}
if (!color_found) /* no more free color cells */
- Error(ERR_EXIT, "cannot allocate enough color cells");
+ {
+ SetError(error, "cannot allocate enough color cells");
+ return NULL;
+ }
xcolor.pixel = xcolor2.pixel;
xcolor_private[xcolor.pixel] = xcolor;
break;
default:
- Error(ERR_RETURN, "display class not supported");
- Error(ERR_EXIT, "DirectColor, TrueColor or PseudoColor display needed");
- break;
+ Error(ERR_RETURN,"DirectColor, TrueColor or PseudoColor display needed");
+ SetError(error, "display class not supported");
+ return NULL;
}
#if DEBUG_TIMING
/* create XImage from internal image structure and convert it to Pixmap */
- bits_per_pixel = bitsPerPixelAtDepth(display, screen, depth);
- bytes_per_pixel = (bits_per_pixel + 7) / 8;
+ display_bits_per_pixel = bitsPerPixelAtDepth(display, screen, depth);
+ display_bytes_per_pixel = (display_bits_per_pixel + 7) / 8;
ximage = XCreateImage(display, visual, depth, ZPixmap, 0,
NULL, image->width, image->height,
- 8, image->width * bytes_per_pixel);
+ 8, image->width * display_bytes_per_pixel);
ximage->data =
- checked_malloc(image->width * image->height * bytes_per_pixel);
+ checked_malloc(image->width * image->height * display_bytes_per_pixel);
ximage->byte_order = MSBFirst;
src_ptr = image->data;
redvalue[image->rgb.red[pixval] >> 8] |
greenvalue[image->rgb.green[pixval] >> 8] |
bluevalue[image->rgb.blue[pixval] >> 8];
- value_to_memory(pixval, dst_ptr, bytes_per_pixel);
- dst_ptr += bytes_per_pixel;
+ value_to_memory(pixval, dst_ptr, display_bytes_per_pixel);
+ dst_ptr += display_bytes_per_pixel;
}
}
break;
{
for (x=0; x<image->width; x++)
{
- pixval = memory_to_value(src_ptr, image->depth);
+ pixval = memory_to_value(src_ptr, image->bytes_per_pixel);
pixval =
redvalue[TRUECOLOR_RED(pixval)] |
greenvalue[TRUECOLOR_GREEN(pixval)] |
bluevalue[TRUECOLOR_BLUE(pixval)];
- value_to_memory(pixval, dst_ptr, bytes_per_pixel);
- src_ptr += image->depth;
- dst_ptr += bytes_per_pixel;
+ value_to_memory(pixval, dst_ptr, display_bytes_per_pixel);
+ src_ptr += image->bytes_per_pixel;
+ dst_ptr += display_bytes_per_pixel;
}
}
break;
}
default:
- Error(ERR_RETURN, "image type not supported");
- Error(ERR_EXIT, "RGB or TrueColor image needed");
- break;
+ Error(ERR_RETURN, "RGB or TrueColor image needed");
+ SetError(error, "image type not supported");
+ return NULL;
}
break;
}
case PseudoColor:
{
- if (bytes_per_pixel == 1) /* (common) special case */
+ if (display_bytes_per_pixel == 1) /* special case */
{
for (y=0; y<image->height; y++)
for (x=0; x<image->width; x++)
for (x=0; x<image->width; x++)
{
value_to_memory(ximageinfo->index[c + *src_ptr++],
- dst_ptr, bytes_per_pixel);
- dst_ptr += bytes_per_pixel;
+ dst_ptr, display_bytes_per_pixel);
+ dst_ptr += display_bytes_per_pixel;
}
}
}
}
default:
- Error(ERR_RETURN, "display class not supported");
- Error(ERR_EXIT, "DirectColor, TrueColor or PseudoColor display needed");
- break;
+ Error(ERR_RETURN,"DirectColor, TrueColor or PseudoColor display needed");
+ SetError(error, "display class not supported");
+ return NULL;
}
if (redvalue)
/* convert image structure to X11 Pixmap */
if (!(ximageinfo = Image_to_Pixmap(display, screen, visual,
window, gc, depth, image)))
- Error(ERR_EXIT, "cannot convert Image to Pixmap");
+ return PCX_OtherError;
/* if a private colormap has been created, install it */
if (ximageinfo->cmap != DefaultColormap(display, screen))